feat(behavior_path_start_planner_module): add support for rqt reconfig #6492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
component:planning
danielsanchezaran
added
the
run:build-and-test-differential
danielsanchezaran
requested review from
kosuke55,
kyoichi-sugahara,
soblin,
satoshi-ota,
shmpwk,
TomohitoAndo and
tkimura4
as code owners
|
thanks!!!!! just a question, can we change the vector parameter too? updateParam for this parameter is not found in the diff. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6492 +/- ##
==========================================
- Coverage 14.66% 14.63% -0.04%
==========================================
Files 1900 1900
Lines 130361 130638 +277
Branches 38381 38381
==========================================
Hits 19123 19123
- Misses 89780 90057 +277
Partials 21458 21458
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kyoichi-sugahara
approved these changes
Feb 26, 2024
Ah, it seems some params were missing (the script I used to get all the updateParams lines is not perfect) I think I have added them all now |
danielsanchezaran
force-pushed
the
feat/add-rqt-reconfig-support-for-bpspm
branch
from
5fb1406 to
d9f9004
Compare
danielsanchezaran
force-pushed
the
feat/add-rqt-reconfig-support-for-bpspm
branch
from
d9f9004 to
9881a06
Compare
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
danielsanchezaran
force-pushed
the
feat/add-rqt-reconfig-support-for-bpspm
branch
from
9881a06 to
2a37942
Compare
danielsanchezaran
merged commit 2acb840
into
autowarefoundation:main
19 of 23 checks passed
danielsanchezaran
deleted the
feat/add-rqt-reconfig-support-for-bpspm
branch
danielsanchezaran
added a commit
to tier4/autoware.universe
that referenced
this pull request
Feb 28, 2024
autowarefoundation#6492) * add support for rqt reconfig Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * add missing params to update Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> --------- Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
HansRobo
pushed a commit
that referenced
this pull request
Mar 12, 2024
#6492) * add support for rqt reconfig Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * add missing params to update Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> --------- Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
autowarefoundation#6492) * add support for rqt reconfig Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * add missing params to update Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> --------- Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for rqt reconfigure for the start planner
Tests performed
Tests in PSim:
cap-.2024-02-26-16-36-02.mp4
In the above example, I use a custom script to place the ego vehicle in the same position for each test, at the beggining, both geometric pull out and shift pull out are enabled, then I disable both and call my script to place the start and goal in the same pose, this time, there is no path since both pull out methods are disabled (params updated successfully) , then I enable geometric_pull out and set the ego poses again and a path is generated using geom pull out
Note that the start and goal pose must be placed again after updating parameters.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.